Support RN new architecture #7576
Conversation
There was a problem hiding this comment.
I focused on the lib files, not the playground changes since I guess are the ones required for the new arch.
I'm wondering how did you come with all the changes for the .podspec files.
Are those changes suggested by React Native for native libs maintainers or something? Because I'd like to know more about new architecture.
| ss.dependency 'React-RCTFabric' | ||
| ss.dependency 'React-Fabric' | ||
| ss.dependency 'RCT-Folly/Fabric' | ||
| reactJson = JSON.parse(File.read(File.join(__dir__, "node_modules", "react-native", "package.json"))) |
There was a problem hiding this comment.
I think this could fail in a monorepo, where react-native dependency could be located in other folder than local node_modules.
Anyway, it would be very unlikely since hoisting react-native bring too many problems.
Just wondering if there is an easy way to provide a fallback in case that happens (e.g. specifying the RN version manually).
What do you think @yogevbd?
There was a problem hiding this comment.
out of curiosity is this comment holding up the PR? perhaps the fallback can be about setting up an env var?
Just wondering what's pending to push this forward ;)
|
out of curiosity are we going to support an sync api with this change ? |
|
Will this ever be supported? The new Arch is out for a while now. |
|
Any progress on this? |
|
@yogevbd And then merge my Android fabric support PR #7720 into yours - this one Any thoughts? |
|
@yogevbd I see tests still failing here. What's remaining to get this one merged? I remember you made progress w/ tests and they were passing, is it just a matter of pushing your new code? |
|
Closing in favor of #7744 |
No description provided.