pass type and animationType to DrawerControllerIOS in startSingleScreenApp #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timxyz
pushed a commit
to 3sidedcube/react-native-navigation
that referenced
this pull request
Aug 30, 2016
# By Guy Carmeli (8) and Daniel Zlotin (7) # Via Guy Carmeli * 'master' of github.com:wix/react-native-navigation: 2.0.0-experimental.86 Use leftButtons api on Android like in iOS 2.0.0-experimental.85 fixed drawer animation warning on iOS 2.0.0-experimental.84 fixed wix#66 2.0.0-experimental.83 fix killed in background bug && update package.json Revert "Call recreate instead of finish and startActivity" 2.0.0-experimental.82 2.0.0-experimental.81 Fix screen style in modal's initial screen 2.0.0-experimental.80 2.0.0-experimental.79 Fix bottomTab not getting correct label on Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently getting this warning:
Set to default type=MMdrawer animationType=slideSetting the props made no difference when running in single screen app mode as the props weren't passed to the DrawerControllerIOS component