Always merge options with parent controller #5606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, mergeOptions would merge with parent controller only if mergeOptions was called with a componentId. This commit fixes the issue and makes options merge correctly even when called with a layoutId.
guyca
added a commit
that referenced
this pull request
Oct 31, 2019
Until now, mergeOptions would merge with parent controller only if mergeOptions was called with a componentId. This commit fixes the issue and makes options merge correctly even when called with a layoutId. # Conflicts: # lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ChildController.java # lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/ComponentViewController.java # lib/android/app/src/test/java/com/reactnativenavigation/mocks/SimpleViewController.java # playground/android/build.gradle
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
Until now, mergeOptions would merge with parent controller only if mergeOptions was called with a componentId. This commit fixes the issue and makes options merge correctly even when called with a layoutId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, mergeOptions would merge with parent controller only if mergeOptions was called with
a componentId. This commit fixes the issue and makes options merge correctly even when called with a layoutId.