Skip to content

Updated OptionsAnimations and OptionsAnimationSeparate to match native implementations #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated OptionsAnimations and OptionsAnimationSeparate to match native implementations #4856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/commands/OptionsProcessor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ describe('navigation options', () => {
blurOnUnmount: false,
popGesture: false,
modalPresentationStyle: OptionsModalPresentationStyle.fullScreen,
animations: { dismissModal: { alpha: { from: 0, to: 1 } } },
animations: { dismissModal: { content: { alpha: { from: 0, to: 1 } } } },
};
uut.processOptions(options);
expect(options).toEqual({
blurOnUnmount: false,
popGesture: false,
modalPresentationStyle: OptionsModalPresentationStyle.fullScreen,
animations: { dismissModal: { alpha: { from: 0, to: 1 } } },
animations: { dismissModal: { content: { alpha: { from: 0, to: 1 } } } },
});
});

Expand Down
15 changes: 12 additions & 3 deletions lib/src/interfaces/Options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,11 @@ export interface OptionsAnimationSeparate {
```
*/
waitForRender?: boolean;
/**
* Enable or disable the animation
* @default true
*/
enabled?: boolean;
/**
* Configure animations for the top bar
*/
Expand All @@ -780,7 +785,7 @@ export interface OptionsAnimations {
/**
* Configure the setRoot animation
*/
setRoot?: OptionsAnimationProperties;
setRoot?: OptionsAnimationSeparate;
/**
* Configure what animates when a screen is pushed
*/
Expand All @@ -792,11 +797,15 @@ export interface OptionsAnimations {
/**
* Configure what animates when modal is shown
*/
showModal?: OptionsAnimationProperties;
showModal?: OptionsAnimationSeparate;
/**
* Configure what animates when modal is dismissed
*/
dismissModal?: OptionsAnimationProperties;
dismissModal?: OptionsAnimationSeparate;
/**
* Configure what animates when stack root is changed
*/
setStackRoot?: OptionsAnimationSeparate;
}

export interface OptionsCustomTransition {
Expand Down