Fix launch image matching for iPhone XR/XS Max portrait #4707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogevbd
approved these changes
Feb 11, 2019
Contributor
|
Is there anyway to make more robust solution because when Apple release new iPhone with new screen size then we again see only a black screen. I think if we can't find matching splash image then we just have black splash and start the app normally. Because now if we don't have matching splash screen then the app just stays there and does nothing xD |
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes so that the splash screen properly resolves to the appropriate launch image for the new iPhone screen sizes released last year.