Skip to content

Conversation

@yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Feb 7, 2019

{
  topBar: {
    rightButtons: [{
      id: '',
      icon: 'require()'
      iconInsets: {
        left: 15,
        right: 15
      }
    }]
  }
}

As default option:

{
  topBar: {
    rightButtonStyle: {
      iconInsets: {
        left: 15,
        right: 15
      }
    }
  }
}

@yogevbd yogevbd merged commit 545e5fe into master Feb 7, 2019
@yogevbd yogevbd deleted the iconInsets branch February 7, 2019 09:35
@calendee
Copy link

@yogevbd Can you describe what the iconInsets property does? I've applied it to my buttons hoping to solve issue #5000, but it has no effect that I can see. What is an "inset"?

@yomybaby
Copy link
Contributor

This PR make #4708 issue.

Scrolling has higher priority than below function.

[self.target performSelector:self.action
						  withObject:self
						  afterDelay:0];

I don't know how to fix this exactly. But previous code is work properly. :)

yomybaby added a commit to yomybaby/react-native-navigation that referenced this pull request Jul 20, 2019
yomybaby added a commit to yomybaby/react-native-navigation that referenced this pull request Oct 18, 2019
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
* Add button.iconInsets

* Define iconInsets in Options.ts

* Apply color on button iconImage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants