SetRoot wait for render #4688
Merged
SetRoot wait for render #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4da8cfb.
yogevbd
force-pushed
the
setRootWaitForRender
branch
from
4e101d1 to
8c35175
Compare
yogevbd
force-pushed
the
setRootWaitForRender
branch
from
8c35175 to
fb90e8e
Compare
Collaborator
|
🔥 🔥 🔥 |
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* Layout changes * WIP * Revert "Layout changes" This reverts commit 4da8cfb. * Clean topBar.component and topBar.background.component when not needed * Move custom components login from viewController to presenters * Change waitForRender and enabled property from primitive bool to Bool object * Fix ios unit tests * Add unit tests * Remove RNNReactView observer when view ready * Load react components from component manager * Remove createCustomReactView duplication * Handle render children in each Layout * Wait for navigation presenter components render, refactor RNNTitleViewHelper * Fix unit tests * Add waitForRender for custom react components * Fixes e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.