Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Indicator in FlatList doesn't work correctly with largeTitle #5815

Open
sallar opened this issue Dec 30, 2019 · 8 comments
Open

Refresh Indicator in FlatList doesn't work correctly with largeTitle #5815

sallar opened this issue Dec 30, 2019 · 8 comments
Assignees
@yogevbd
Labels
📌 pinned platform: iOS type: accepted/bug

Comments

@sallar
Copy link
Contributor

sallar commented Dec 30, 2019

Issue Description

Im creating a new issue since the previous one is marked as stale for some reason. #3137
If you use largeTitle in a view that hosts a FlatList, the Refresh Indicator is shown at a position that is not correct.

The current workaround is apparently to use react-native-tableview which uses the native UITableView, which works nicely, but that has it's own issues and also doesn't support android.

Steps to Reproduce / Code Snippets / Screenshots

Screenshot 2019-12-13 at 0 37 44

  • Use largeTitle in a screen
  • Embed a refreshable FlatList in that view
  • Drag down to see the indicator

Environment

  • React Native Navigation version: 4.0.5
  • React Native version: 0.61.4
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Simulator / Debug
@guyca guyca added platform: iOS user: requires reproduction This issue requires a reproduction before maintainers can work on it labels Dec 30, 2019
@guyca
Copy link
Collaborator

guyca commented Dec 30, 2019 •
edited
Loading

Hey @sallar 👋
Can you please fork the library and add a screen where the issue reproduces to the playground app?

@sallar
Copy link
Contributor Author

sallar commented Dec 30, 2019

Hey @guyca sure thing. On it

@sallar
Copy link
Contributor Author

sallar commented Dec 30, 2019

Actually @guyca I just saw that this issue is already visible in Playground. You can find it in FlatListScreen.js:

Kapture 2019-12-30 at 13 44 21

The correct behaviour is this:

Kapture 2019-12-30 at 13 47 16

you can see that the loading indicator is correctly on top. not behind the search box or title. The second video is using react-native-tableview instead of FlatList.

The react-navigation module has added new "native" stack module that does this correctly, so I know it should be possible to fix this. I just dont know how :D

@sallar
Copy link
Contributor Author

sallar commented Jan 2, 2020

@guyca the issue still has "requires reproduction" tag, do I need do anything extra?

@ItsNoHax ItsNoHax added type: accepted/bug 📌 pinned and removed user: requires reproduction This issue requires a reproduction before maintainers can work on it labels Jan 7, 2020
@ItsNoHax
Copy link
Collaborator

ItsNoHax commented Jan 7, 2020

@sallar I have updated the tags for you. Thanks for looking into it.

@sallar
Copy link
Contributor Author

sallar commented Jan 7, 2020

Thanks @ItsNoHax. Im not even sure if this can be fixed in this project, but this is a big obstacle currently for making native-looking apps on iOS 13. It's not a big deal, but would be nice to figure out where the issue comes from.

@remstos
Copy link

remstos commented Mar 25, 2020

It appears that a RN fix is coming that would solve this issue: facebook/react-native#28236

@sallar
Copy link
Contributor Author

sallar commented Mar 25, 2020

That’s amazing 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogevbd yogevbd

Labels
📌 pinned platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sallar @ItsNoHax @remstos @yogevbd @guyca