-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace deprecated link process (#6269)
Running `react-native link` will be deprecated in the following major versions of rn-cli. React Native Navigation recommends the `react-native link` command to install the library, although it already implements Autolinking. These causes the library to make unnecessary modifications to the project it's installing to, which are already handled in Autolinking. However, since manual steps need to be completed, we are benefiting from the `"postlink"` hook in the `link` command which allows to run any set of scripts after the link has completed, in our case the node script `./autolink/postlink/run.js`. I propose using the `bin` field from npm's package.json to perform these tasks from a single command and without using react-native link. I named it "rnn-link" and it can be run via `npx rnn-link` from the root of the project right after `yarn add react-native-navigation`. I've updated the docs to reflect this, plus some minor changes I feel are necessary, after some work with these scripts and the install process. I still feel some parts are confusing, specially the iOS manual link (the hardcore way). Feel free to propose any changes! This was developed with the support of @underscopeio 🥳
- Loading branch information
Eduardo Pelitti
authored
Jun 9, 2020
1 parent
daa48ca
commit 4c3ed45
Showing
3 changed files
with
32 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters