Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpandableCalendar - Added height calculation on layout instead of hard coded header height #2599

Merged
merged 18 commits into from
Feb 26, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3d849de
Added height calculation on layout instead of hardcoded header height
nitzanyiz Feb 9, 2025
9904034
Removed horizontal handling
nitzanyiz Feb 9, 2025
5f1bbbf
Fix missing newline at end of file in useHeaderHeight.ts
nitzanyiz Feb 9, 2025
987f7b8
Remove unused lodash import in useHeaderHeight.ts
nitzanyiz Feb 9, 2025
e7b4b46
Refactor useHeaderHeight to use inferred type for headerHeight state
nitzanyiz Feb 9, 2025
35e2bb7
Changed the way the header height is effecting the styles
nitzanyiz Feb 10, 2025
6320d8f
Refactor ExpandableCalendar to manage header height state locally and…
nitzanyiz Feb 12, 2025
6694f80
Merge remote-tracking branch 'origin' into fix/ExpandabelHeaderHeader…
nitzanyiz Feb 16, 2025
e11ebfe
Added onHeaderLayout flag and default header heights
nitzanyiz Feb 17, 2025
f4d34b7
Removed memo from _headerStyles object so its updated onClose
nitzanyiz Feb 17, 2025
b56158d
Revert default header height
nitzanyiz Feb 17, 2025
063c0f8
Removed header height from week container
nitzanyiz Feb 19, 2025
fa41fbb
Remove constant for header height in style file
nitzanyiz Feb 20, 2025
6fb7beb
Pass conditional onHeaderLayout to CalendarHeader and reset shouldMea…
nitzanyiz Feb 20, 2025
02e4d9d
Added open height change on header change
nitzanyiz Feb 20, 2025
3f1481d
Rename closedHeightWithKnob to closeHeight
nitzanyiz Feb 20, 2025
0b741f0
Added comments to explain the ref flag and pan responder dependencies
nitzanyiz Feb 23, 2025
3812986
Fix open height calculation by adjusting knob container height condition
nitzanyiz Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin' into fix/ExpandabelHeaderHeader…
…Height
  • Loading branch information
nitzanyiz committed Feb 16, 2025
commit 6694f80e72f5934696e8b5f32a7c3102b786e67e

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.