Added descending order to CalendarList #2257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaywags
approved these changes
Jun 22, 2023
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
trvnvy
approved these changes
Nov 28, 2023
|
@yakirza17 Could I ask you to check this and approve it pls? |
| @@ -120,7 +123,7 @@ const CalendarList = (props: CalendarListProps & ContextProp, ref: any) => { | |||
| const rangeDate = initialDate.current?.clone().addMonths(i - pastScrollRange, true); | |||
| months.push(rangeDate); | |||
| } | |||
| return months; | |||
| return descendingOrder ? months.reverse() : months; | |||
| }, [pastScrollRange, futureScrollRange]); | |||
There was a problem hiding this comment.
}, [descendingOrder, pastScrollRange, futureScrollRange]);
|
@biddano Sorry for the late review. This feature looks great and I would like to review it if you can fix the PR please |
|
This is a needed feature. Can you please merge it? |
jcedborger
suggested changes
Feb 3, 2025
There was a problem hiding this comment.
Please see @ozhuk-hacken's comment. After that, please merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow users the flexibility to view CalendarList months in descending order rather than ascending order (current functionality). Added an optional descendingOrder prop to CalendarList for this (defaults to false).