Agenda crashes with RN 0.78

[bmatasar]

After switching to RN 0.78, the Agenda component crashes with the infamous

Warning: Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
This error is located at:
at ReservationList (http://10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.calendartest&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:103469:36)
at RCTView ()
at View (http://10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.calendartest&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:47523:43)
at RCTView ()
at View (http://10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.calendartest&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:47523:43)
at Agenda (http://10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.calendartest&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:97582:36)

[bmatasar]

Code example:

import React, {useState} from 'react';
import {StatusBar, View} from 'react-native';
import {Agenda, CalendarProvider} from 'react-native-calendars';

function App(): React.JSX.Element {
  const [currentDate, setCurrentDate] = useState(new Date().toDateString());

  return (
    <View>
      <StatusBar barStyle={'light-content'} />

      <CalendarProvider date={currentDate}>
        <Agenda />
      </CalendarProvider>
    </View>
  );
}

export default App;

[drumsSandoval]

Same error

[dmohler20]

I am also having the same issue

[RameeshSayone]

any fix on this issue

[iyanushow]

same here, any fix?

[dmohler20]

I was messing around a little bit, and the issue seems to be coming from here in the ReservationList component class.

componentDidUpdate(prevProps) {
  if (this.props.topDay && prevProps.topDay && prevProps !== this.props) {
    if (!sameDate(prevProps.topDay, this.props.topDay)) {
      this.setState({ reservations: [] }, () => this.updateReservations(this.props));
    } else {
      this.updateReservations(this.props);
    }
  }
}

I think the problem is with the prevProps !== this.props check. I modified it slightly to test it out:

componentDidUpdate(prevProps) {
  if (this.props.topDay && prevProps.topDay && 
      (!sameDate(prevProps.topDay, this.props.topDay) || 
       prevProps.items !== this.props.items || 
       prevProps.selectedDay !== this.props.selectedDay)) {
    
    if (!sameDate(prevProps.topDay, this.props.topDay)) {
      this.setState({ reservations: [] }, () => this.updateReservations(this.props));
    } else {
      this.updateReservations(this.props);
    }
  }
}

This initially fixes it when you are looking at the current week at the top, but when you switch to the full month selection that no longer works. So there is more that needs done or updated, or maybe i missed the true issue completely.

I created a PR, with slightly updated coding. It looks the the other error I encountered is only on Android devices, and is there even in the current version on older version or RN as well.

Here is a link to the PR

[eneskooo]

same issue, waiting the fix

[gkasireddy202]

The app is crashed on iOS.

react-native:0.78.0 and react-native-calendars:1.1310.0

[fatihtelis]

The app is crashed on iOS.

react-native:0.78.0 and react-native-calendars:1.1310.0

I got the same error.
The issue is related with React 19 which is shipped with RN 0.78.
When I downgraded to RN 0.77 with React 18.3.1, the issue is solved.

I've encountered various bugs with React 19 when using other packages, so it's safer to stick with the previous version for now.

[bmatasar]

#2624 is a possible fix. Let's see what the team chooses to implement.

[ashishAmz]

is it fixed?

[bmatasar]

There are at least 2 PR's with fixes. Let's see what WIX team will do about it.

[voulgarakis]

same issue

[bmatasar]

It looks like they have released an update but still without the fix.