Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update info on how to update artifacts snapshots for e2e #973

Merged
merged 1 commit into from
Oct 8, 2018
Merged

docs: update info on how to update artifacts snapshots for e2e #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: update info on how to update artifacts snapshots for e2e
  • Loading branch information
@noomorph
noomorph committed Oct 8, 2018
commit bbd16a433ca491213e577b841a949f28f52631f8
12 changes: 12 additions & 0 deletions docs/Guide.Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ on macOS environment variables can be exported to desktop applications by adding
launchctl setenv PATH $PATH
```

##### Changing Detox e2e test suite

If you add, rename, or delete a test in `detox/test/e2e` suite, you also have to update Jest snapshots
of expected artifacts. It is usually done in five steps:

1. In `detox/test` project, run all end-to-end tests on iOS with `npm run e2e:ios-multi`.
2. Update the snapshots with: `npm run verify-artifacts:ios -- -u`.
3. Re-run Android tests with `npm run e2e:android`.
4. Update the snapshots with: `npm run verify-artifacts:android -- -u`.
5. Add the snapshots to your Git commit:
* Android: `detox/test/scripts/__snapshots__/verify_artifacts_are_not_missing.android.test.js.snap`
* iOS: `detox/test/scripts/__snapshots__/verify_artifacts_are_not_missing.ios.test.js.snap`

#### 3. Android Native tests

Expand Down