New logger subsystem (Bunyan) #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
previously requested changes
Jul 23, 2018
| } | ||
|
|
||
| async onTerminate() { | ||
| if (this._artifactPlugins.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| log.info('ArtifactsManager', 'finalizing all artifacts, this can take some time'); | ||
| log.info({ event: 'ARTIFACTS_FINALIZATION_START' }, 'finalizing the recorded artifacts...'); |
| await this._emit('onTerminate', []); | ||
| await Promise.all(this._onIdleCallbacks.splice(0).map(this._executeIdleCallback)); | ||
| await this._idlePromise; | ||
|
|
||
| await Promise.all(this._activeArtifacts.map(artifact => artifact.discard())); | ||
| await this._idlePromise; | ||
| this._artifactPlugins.splice(0); | ||
| log.info('ArtifactsManager', 'finalized all artifacts'); | ||
| log.trace({ event: 'ARTIFACTS_FINALIZED' }, 'done'); | ||
| } | ||
|
|
||
| async _emit(methodName, args) { |
There was a problem hiding this comment.
add logger inside emit instead of duplicating across ArtifactsManager.js
| @@ -68,18 +73,21 @@ class SimulatorLogRecording extends Artifact { | |||
|
|
|||
| _close() { | |||
| if (this._logStream) { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
detox/src/index.js
Outdated
| @@ -1,9 +1,11 @@ | |||
| const _ = require('lodash'); | |||
| const fs = require('fs'); | |||
noomorph
force-pushed
the
noomorph/powerlogs
branch
from
bf9cd5d to
0b7142e
Compare
rotemmiz
changed the title
rotemmiz
changed the title
|
This thread has been automatically locked to prevent bumping of old threads. Instead, if you believe the issue still reproduces, please open a new issue and provide all the required information. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset:
detox-serveris merged insidedetoxpackage.--record-logsvalue is set toallorfailing, Detox also saves console logs as a pair of plain-text and JSON files in the location specified by--artifacts-locationparameter. And now you can query JSON log files byjq,bunyanand similar tools.bunyanandbunyan-debug-stream, some parts of log messages that have been swallowed by Jest previously, now are perfectly visible in a command line.detox.init(), the build logs an error and exits. It makes build logs more compact and reasonable as the Jest behavior is to continue even whenbeforeAllfails. Although this is a hack, but it is marked with a todo item.verbose,sillyandwssare deprecated. New--no-coloroption.loglevelandno-colorparams.--loglevel info(default)Before
After
--loglevel verbose(default)Before
After