-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix element screenshots for react-native-skia and similar #4493
base: master
Are you sure you want to change the base?
[WIP] Fix element screenshots for react-native-skia and similar #4493
Conversation
In my own app, the fix in this pr is working. I am having trouble adding rn skia to the detox test app though to create an e2e test. As soon as I add skia, I get the following error:
Unfortunately I have no real experience how native module resolution in react-native works and due to the lack of google results on this I am a bit stuck with this. Do you guys have any hints or ideas on how to solve this or even to debug this further? I asked the same question to wcandillion here: Shopify/react-native-skia#1880 as well as I am not sure if this is a skia problem or a problem of how the Detox test app is configured. |
Also see:
Shopify/react-native-skia#1880
In this pull request, I have implemented a method to manually render TextureView in android apps as they do not support rendering themselves.
This is still a WIP as my fix itself works, but the e2e test is still missing, as I have probems compiling the sample app with react-native-skia