fix: prevent flooding currentStatus messages #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
changed the title
d4vidi
approved these changes
Sep 15, 2020
rotemmiz
reviewed
Sep 15, 2020
| @@ -131,7 +131,7 @@ class Client { | |||
| } | |||
|
|
|||
| async sendAction(action) { | |||
| if (this.slowInvocationTimeout) { | |||
| if (this.slowInvocationTimeout && action.type !== 'currentStatus') { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes flood of
currentStatusmessages when the app is really busy and cannot reply.Each currentStatus request generates one extra currentStatus request, and that goes up quite fast.
Looks like a regression after 41400bfc (kudos to @d4vidi for the investigation)