Skip to content

Conversation

ferdicus
Copy link
Contributor

@ferdicus ferdicus commented Jan 7, 2020

  • This is a small change
  • This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
typo ext.detoxKotlinVerion -> ext.detoxKotlinVersion

typo `ext.detoxKotlinVerion` -> `ext.detoxKotlinVersion`
@ferdicus ferdicus requested a review from rotemmiz as a code owner January 7, 2020 15:38
@LeoNatan
Copy link
Contributor

LeoNatan commented Jan 8, 2020

Duplicate PR. Closing

@LeoNatan LeoNatan closed this Jan 8, 2020
@ferdicus
Copy link
Contributor Author

ferdicus commented Jan 8, 2020

Oh, sorry bout that - can you please link to the duplicate, I couldn't find anything.

Thanks in advance.

@d4vidi
Copy link
Collaborator

d4vidi commented Jan 8, 2020

I double checked to see my memory hasn't failed me: this is not a duplicate

@d4vidi d4vidi reopened this Jan 8, 2020
@d4vidi
Copy link
Collaborator

d4vidi commented Jan 8, 2020

Nevertheless, putting aside how it strikes me that this typo exists to begin with, neither this nor #1835 are sufficient.
In any case, in order to accept this we need to do all of this in one go:

  1. Apply the minor change in Update build.gradle #1835, here
  2. Apply the fix to where detoxKotlinVersion is set in our demo app.
  3. Think through whether this is in a way a breaking change (affects only detox-Android-compiling users, probably not too many out there)

BTW this is related to #1833, which I had to revert because of this. So also:
4. Update documentation as in #1833.

@d4vidi d4vidi mentioned this pull request Jan 8, 2020
2 tasks
@stale
Copy link

stale bot commented Feb 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
For more information on bots in this reporsitory, read this discussion.

@stale stale bot added the 🏚 stale label Feb 8, 2020
@stale
Copy link

stale bot commented Feb 15, 2020

The issue has been closed for inactivity.

@stale stale bot closed this Feb 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants