Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle instrumentation args passed in as launch-args #1815

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Properly handle instrumentation args passed in as launch-args #1815

merged 1 commit into from
Dec 25, 2019

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Dec 24, 2019

Description:

Fixes #1804 by introducing these two changes:

  1. On the tester (JS) side, allow reserved instrumentation args to pass-through unencoded.
  2. On the Android-native side, refrain from passing such instrumentation args into the activity through the intent's extras.

@d4vidi d4vidi requested a review from rotemmiz December 24, 2019 16:21
@d4vidi d4vidi self-assigned this Dec 24, 2019
@d4vidi d4vidi merged commit d90ed35 into master Dec 25, 2019
@d4vidi d4vidi deleted the reserved-android-instrum-args branch December 25, 2019 13:04
@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees

@d4vidi d4vidi

Labels
platform: android type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow not encoded launchArgs for AndroidDriver
1 participant
@d4vidi