Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade project to RN61 with CocoaPods #1713

Merged
merged 10 commits into from
Dec 24, 2019
Merged

Upgrade project to RN61 with CocoaPods #1713

merged 10 commits into from
Dec 24, 2019

Conversation

LeoNatan
Copy link
Contributor

@LeoNatan LeoNatan commented Oct 24, 2019 •
edited
Loading

  • Remove componentWillMount functions
  • Remove PushNotificationIOS
  • Add pod install step to lerna bootstrap

Todo:

  • Figure out CI
  • Remove iOS sample projects from CI (no desire to maintain them with CocoaPods or at all)

@LeoNatan
Upgrade project to RN61 with CocoaPods
dd99759 
Remove componentWillMount functions
Remove PushNotificationIOS
Add pod install step to lerna bootstrap
@LeoNatan LeoNatan requested a review from rotemmiz as a code owner October 24, 2019 17:47
EvanBacon
EvanBacon reviewed Oct 24, 2019
View reviewed changes
scripts/install.ios.sh
HOMEBREW_NO_INSTALL_CLEANUP=1 HOMEBREW_NO_AUTO_UPDATE=1 brew tap wix/brew
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

This was referenced Oct 24, 2019
Closed
Merged
@msand
Copy link
Contributor

msand commented Nov 5, 2019

It seems like the latest version of Detox works fine with v0.61.4 of react-native as well: msand/react-native-svg-e2e#13

@LeoNatan
Copy link
Contributor Author

LeoNatan commented Nov 5, 2019

This PR is only bureaucracy to get the test project and CI to work with 61.x. Detox on iOS should support RN 61 without issues as far as I know.

@msand
Copy link
Contributor

msand commented Nov 5, 2019

Any known issues on android? At least building and taking screenshots of all the tests in the rnsvg-e2e repo seem to work correctly.

@LeoNatan
Copy link
Contributor Author

LeoNatan commented Nov 5, 2019

Android is tracked here: #1731

@LeoNatan
Copy link
Contributor Author

@rotemmiz Reminder. Thanks

@rotemmiz
Copy link
Member

You're welcome @LeoNatan 😗

@LeoNatan
Copy link
Contributor Author

It just werks???

@LeoNatan LeoNatan merged commit 94bd06c into master Dec 24, 2019
@d4vidi
Copy link
Collaborator

d4vidi commented Dec 25, 2019

Somehow the builds are red now - with stuff related to pods, @LeoNatan could you check it out plz?

@LeoNatan
Copy link
Contributor Author

@d4vidi Sure

@LeoNatan
Copy link
Contributor Author

@d4vidi The error is caused by postinstall somehow:

08:06:53 lerna ERR! execute Error occured with 'undefined' while running 'npm run postinstall'

And since cocoa pods looks for its dependencies in node_modules/, it fails.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2019
@LeoNatan LeoNatan deleted the RN61CocoaPods branch January 25, 2020 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EvanBacon EvanBacon EvanBacon left review comments

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeoNatan @msand @rotemmiz @d4vidi @EvanBacon