fixing the slider logic #pr #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielWix
commented
Jul 28, 2025
packages/headless-components/stores/src/services/products-list-filters-service.ts
Show resolved
Hide resolved
arielWix
commented
Jul 28, 2025
examples/astro-stores-demo/src/components/store/DualRangeSlider.tsx
Outdated
Show resolved
Hide resolved
arielWix
commented
Jul 28, 2025
examples/astro-stores-demo/src/components/store/DualRangeSlider.tsx
Outdated
Show resolved
Hide resolved
arielWix
commented
Jul 28, 2025
examples/astro-stores-demo/src/components/store/DualRangeSlider.tsx
Outdated
Show resolved
Hide resolved
arielWix
commented
Jul 28, 2025
examples/astro-stores-demo/src/components/store/DualRangeSlider.tsx
Outdated
Show resolved
Hide resolved
nitayneeman
reviewed
Jul 28, 2025
| const minPrice = getMinPrice(aggregationData); | ||
| const maxPrice = getMaxPrice(aggregationData); | ||
|
|
||
| console.log("Extracted catalog price range:", { minPrice, maxPrice }); |
Comment on lines
139
to
145
| userFilterMinPrice: Signal<number>; | ||
| /** Reactive signal containing the user's selected maximum price filter value */ | ||
| userFilterMaxPrice: Signal<number>; | ||
| /** Reactive signal containing the catalog minimum price (for UI bounds) */ | ||
| catalogMinPrice: Signal<number>; | ||
| /** Reactive signal containing the catalog maximum price (for UI bounds) */ | ||
| catalogMaxPrice: Signal<number>; |
There was a problem hiding this comment.
Let's change the API to:
Suggested change
| userFilterMinPrice: Signal<number>; | |
| /** Reactive signal containing the user's selected maximum price filter value */ | |
| userFilterMaxPrice: Signal<number>; | |
| /** Reactive signal containing the catalog minimum price (for UI bounds) */ | |
| catalogMinPrice: Signal<number>; | |
| /** Reactive signal containing the catalog maximum price (for UI bounds) */ | |
| catalogMaxPrice: Signal<number>; | |
| selectedMinPrice: Signal<number>; | |
| /** Reactive signal containing the user's selected maximum price filter value */ | |
| selectedMaxPrice: Signal<number>; | |
| /** Reactive signal containing the catalog minimum price (for UI bounds) */ | |
| availableMinPrice: Signal<number>; | |
| /** Reactive signal containing the catalog maximum price (for UI bounds) */ | |
| availableMaxPrice: Signal<number>; |
Also in all other places
Paveltarno
pushed a commit
that referenced
this pull request
Aug 13, 2025
ttsahi
pushed a commit
that referenced
this pull request
Aug 17, 2025
valeriihorsharik-wix
pushed a commit
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.