Skip to content

fix saving deactivated domains on websites with iframes#1390

Open
imilka wants to merge 1 commit intodevfrom
1388-iframe-deactivation
Open

fix saving deactivated domains on websites with iframes#1390
imilka wants to merge 1 commit intodevfrom
1388-iframe-deactivation

Conversation

@imilka
Copy link
Contributor

@imilka imilka commented Jan 30, 2025

fixes #1388

@imilka imilka requested a review from lsmith77 January 30, 2025 14:14
@imilka imilka self-assigned this Jan 30, 2025
@lsmith77
Copy link
Contributor

On the Editor it seems like there is another issue, where the highlights go away but the words remain clickable:
image

But on Hubspot your fix does not appear to have resolved the issue:
image

@imilka
Copy link
Contributor Author

imilka commented Jan 31, 2025

@lsmith77 As for the highlights - I have reproduced it and will try to fix.

As for the second issue - I have noticed during testing that there can be a slight delay between sending disabled domains to backend, and updating the list on the backend so the new domain would be returned in the config. So if you click 'disable' and then immediately refresh, you can end up with extension that is still working. It should work fine if refreshed not immediately, or should stop working on next page refresh.

Could you confirm that it stops working as it should after refreshing the page? If that's the case, let me know if you want me to try to do something about it, I can try to make sure disabled domains are saving locally too so there is no race condition, or try to make sure the extension will be properly removed even it has been already initialized...

@lsmith77
Copy link
Contributor

lsmith77 commented Feb 9, 2025

I totally missed your response here.

Test case:

  • I have hubspot.com in my disabled domains list.
  • I re-install and login fresh.
  • I open a CMS page on hubspot.com
  • Still Witty Works shows up.

Are you still motivated to wrap this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Synchronization when Witty is deactived

2 participants