fix saving deactivated domains on websites with iframes#1390
fix saving deactivated domains on websites with iframes#1390
Conversation
|
@lsmith77 As for the highlights - I have reproduced it and will try to fix. As for the second issue - I have noticed during testing that there can be a slight delay between sending disabled domains to backend, and updating the list on the backend so the new domain would be returned in the config. So if you click 'disable' and then immediately refresh, you can end up with extension that is still working. It should work fine if refreshed not immediately, or should stop working on next page refresh. Could you confirm that it stops working as it should after refreshing the page? If that's the case, let me know if you want me to try to do something about it, I can try to make sure disabled domains are saving locally too so there is no race condition, or try to make sure the extension will be properly removed even it has been already initialized... |
|
I totally missed your response here. Test case:
Are you still motivated to wrap this up? |


fixes #1388