Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A set of fixes and features for wit\2 #2472

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

drcpu-github
Copy link
Collaborator

The first four commits are part of #2469.

The latter four commits are all new self-contained patches that introduce a fix or feature, but they build upon each other, so I kept them in the same branch.

@drcpu-github
Copy link
Collaborator Author

drcpu-github commented Jun 27, 2024

Pertaining to above discussions, this is what is currently implemented in the branch up to commit 9ec8d09:

  1. All rf stakers are eligible to produce a block
  2. Block winner comparison is power, vrf, block hash, in that order
  3. If none of the eligible stakers produce a block, they will get slashed proportional to their rank
  4. Validation code to make sure no one stakes on a validator with a different withdrawer address
  5. A way to switch block times moving from V1_8 to V2_0
  6. A bunch of small features and bugfixes

@drcpu-github
Copy link
Collaborator Author

Things to (potentially) still implement (of the top of my head):

  1. Multiplication for the rf factor when more than one block is missing
  2. Move wit/2 constants to a central file
  3. Better ratios for slashing validators

@drcpu-github
Copy link
Collaborator Author

For the sake of an easier review, the block time patch is on #2473.

@aesedepece aesedepece merged commit 0a8869e into witnet:2.0-master Jul 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants