feat(storage): implement iteration support #1714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
commented
Nov 6, 2020
| let hash_key = calculate_sha256(key); | ||
| self.backend.delete(hash_key.as_ref()) | ||
| } | ||
|
|
||
| fn prefix_iterator<'a, 'b: 'a>(&'a self, _prefix: &'b [u8]) -> Result<StorageIterator<'a>> { | ||
| bail!("Iteration is not supported when using encrypted storage") |
There was a problem hiding this comment.
This is a problem: it looks like there is a hidden feature that allows to use an encrypted storage for the node. I would try to deprecate that in some way to avoid future problems. Otherwise, we must always assume that iteration can fail.
|
This was already merged as part of #2159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
prefix_iteratorto theStoragetrait, which allows iterating over all the storage keys that start with the same prefix.This can be used to implement storage migrations by iterating over all the existing keys and updating them to the new format. Also it can be used to check if the storage is empty, or assert that there are no keys with some specific prefix. In this PR it is not used anywhere.
TODO: add tests