-
Notifications
You must be signed in to change notification settings - Fork 42
Whitelist markdown features via config.features
#43
Conversation
- whitelist inline features - update tests - update readme to document whitelisted features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesss, amazing! Two small nitpicks inline then let's ship this
README.md
Outdated
'header-six', | ||
'ordered-list-item', | ||
'unordered-list-item', | ||
CHECKABLE_LIST_ITEM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a string or a constant that needs to be imported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point I'll add that to the readme
@@ -95,8 +95,7 @@ | |||
"peerDependencies": { | |||
"draft-js-plugins-editor": "~2.0.0-rc.1 || 2.0.0-rc2 || 2.0.0-rc1 || 2.0.0-beta12", | |||
"react": "^15.0.0", | |||
"react-dom": "^15.0.0", | |||
"react-portal": "^4.1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this removed on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! react-dom isn't actually removed
@mxstbr all addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you so much! Can't wait to ship this for the message input 🔥
fixes #21
Example: