-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typst): add typst
completion spec
#2144
Conversation
Created based on a commit at typst/typst@c0dbb90
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Overviewsrc/typst.ts:Info: |
Hello @toddlerer,
Please add a 👍 as a reaction to this comment to show that you read this. |
I have read the CLA Document and I hereby sign the CLA |
{ | ||
name: ["-v", "--verbosity"], | ||
description: | ||
"Sets the level of logging verbosity: -v = warning & error, -vv = info, -vvv = debug, -vvvv = trace", | ||
isRepeatable: 4, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of an edge case, but I think it makes sense to split these into two options.
{ | |
name: ["-v", "--verbosity"], | |
description: | |
"Sets the level of logging verbosity: -v = warning & error, -vv = info, -vvv = debug, -vvvv = trace", | |
isRepeatable: 4, | |
}, | |
{ | |
name: ["-v"], | |
description: | |
"Sets the level of logging verbosity", | |
isRepeatable: 4, | |
}, | |
{ | |
name: ["--verbosity"], | |
args: { | |
name: "level", | |
suggestions: ["warning", "error", "info", "debug", "trace"] | |
} | |
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. An option like that --verbosity
might be easier to use. Since I am not an typst maintainer, it might be good if you could suggest it for typst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is verbatim how the command works right now, you can literally repeat --verbosity
up to 4 times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
Add spec for Typst CLI completion