Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update graphite (gt) cli spec #2106

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

DerTimonius
Copy link
Contributor

Thanks for the great CLI tool 🙌

This PR will update the spec for the graphite CLI - adding new commands or removed now unused commands.
Also cohered to the alphabetical ordering of the commands (not necessarily of all subcommands) and added a bit more type safety to the submitOptions.

The changes look more extreme than they actually are, most of the new commands were subcommands before.
To check against the original list, here's the link to the graphite docs: https://graphite.dev/docs/command-reference

Closes #2093

@withfig-bot
Copy link
Collaborator

withfig-bot commented Sep 30, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@DerTimonius
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Sep 30, 2023
@withfig-bot
Copy link
Collaborator

Overview

src/gt.ts:

Info:

URLs:

  • https://app.graphite.dev/activate

@withfig-bot
Copy link
Collaborator

Hello @DerTimonius,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Member

@grant0417 grant0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks great! Thanks for helping maintain the spec!

@grant0417 grant0417 merged commit bc3951f into withfig:master Oct 12, 2023
@withfig withfig locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gt] Update graphite cli spec
3 participants