Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add planter spec #1741

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat: add planter spec #1741

merged 3 commits into from
Oct 12, 2023

Conversation

matthew-ia
Copy link
Contributor

Add spec for planter CLI

@withfig-bot
Copy link
Collaborator

withfig-bot commented Dec 8, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@matthew-ia matthew-ia changed the title add planter spec feat: add planter spec Dec 8, 2022
@withfig-bot
Copy link
Collaborator

Hello @matthew-ia,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@matthew-ia
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedeci
Copy link
Contributor

fedeci commented Dec 8, 2022

Hi @matthew-ia, can you run npm run lint:fix to fix the linting issues and then committing the files?

@Manu1400
Copy link

Manu1400 commented Aug 7, 2023

@matthew-ia I don't find the CLI. Is it https://github.com/matthew-ia/planter ?

@matthew-ia
Copy link
Contributor Author

matthew-ia commented Sep 3, 2023

Hi @matthew-ia, can you run npm run lint:fix to fix the linting issues and then committing the files?

@fedeci For whatever reason, running that command on the old copy of the fork didn't work and flagged a bunch of linting errors across my spec and other specs in ./src/ as well.

I synced my fork with the latest and that seemed to resolve the linting errors.

@matthew-ia
Copy link
Contributor Author

@matthew-ia I don't find the CLI. Is it https://github.com/matthew-ia/planter ?

@Manu1400 the CLI is not yet publicly released but I wanted to go ahead and get the autocomplete spec situated and test with my local/private copies.

@chaynabors chaynabors merged commit a4a5ad4 into withfig:master Oct 12, 2023
@withfig withfig locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants