Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gum): update spec for gum 0.8.0 #1630

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

Fall1ngStar
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Spec update for gum 0.8.0

What is the current behavior? (You can also link to an open issue here)

Spec match gum 0.7.0

#1619

What is the new behavior (if this is a feature change)?

Spec match gum 0.8.0

Additional info:

Just wanted to do a shout out for the amazing typing available and the eslint tools that make adding / updating a spec a breeze 😃

@withfig-bot
Copy link
Collaborator

Overview

src/gum.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @Fall1ngStar,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@clo4 clo4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work @Fall1ngStar! Easy merge 😄

@clo4 clo4 merged commit 14b940c into withfig:master Oct 13, 2022
@clo4
Copy link
Contributor

clo4 commented Oct 13, 2022

Also:

Just wanted to do a shout out for the amazing typing available and the eslint tools that make adding / updating a spec a breeze 😃

@fedeci has put so much work into this and it really pays off! It's so freaking cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants