Skip to content

Conversation

keith
Copy link
Contributor

@keith keith commented Mar 28, 2025

error[E0308]: mismatched types
   --> crates/starpls/src/event_loop.rs:348:45
    |
348 |         if self.req_queue.incoming.complete(resp.id.clone()).is_some() {
    |                                    -------- ^^^^^^^^^^^^^^^ expected `&RequestId`, found `RequestId`
    |                                    |
    |                                    arguments to this method are incorrect
    |
note: method defined here
   --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lsp-server-0.7.8/src/req_queue.rs:47:12
    |
47  |     pub fn complete(&mut self, id: &RequestId) -> Option<I> {
    |            ^^^^^^^^
help: consider borrowing here
    |
348 |         if self.req_queue.incoming.complete(&resp.id.clone()).is_some() {
    |                                             +

```
error[E0308]: mismatched types
   --> crates/starpls/src/event_loop.rs:348:45
    |
348 |         if self.req_queue.incoming.complete(resp.id.clone()).is_some() {
    |                                    -------- ^^^^^^^^^^^^^^^ expected `&RequestId`, found `RequestId`
    |                                    |
    |                                    arguments to this method are incorrect
    |
note: method defined here
   --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lsp-server-0.7.8/src/req_queue.rs:47:12
    |
47  |     pub fn complete(&mut self, id: &RequestId) -> Option<I> {
    |            ^^^^^^^^
help: consider borrowing here
    |
348 |         if self.req_queue.incoming.complete(&resp.id.clone()).is_some() {
    |                                             +
```
@keith
Copy link
Contributor Author

keith commented Mar 28, 2025

threading the needle a bit here, if we update past #382 we need this, otherwise we don't

@withered-magic
Copy link
Owner

Closed now that we're back on stable Rust: #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants