-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Tiktok #2265
Adding Tiktok #2265
Conversation
🦋 Changeset detectedLatest commit: 1254a8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 One thing, I am unsure of optimizing this one and will leave that to fellow maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution 🙌
I left tiny suggestions to the changeset, mostly to match our changeset conventions but other than these details, the PR looks perfect to me.
Note that this PR will only be merged when the next Starlight version is released so that the documentation is only updated when the feature is available to users.
One thing, I am unsure of optimizing this one and will leave that to fellow maintainers
Just ran the SVG in SVGOMG and it results to the same output so we should be good on that front. Thanks for the review too 👍
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Ok, thank you very much ! |
Description
Just edited locally
docs/astro.config.mjs
.