Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tiktok #2265

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Adding Tiktok #2265

merged 4 commits into from
Sep 2, 2024

Conversation

SeraphicRav
Copy link
Contributor

Description

  • Closes Add TikTok in Social links #2255
  • What does this PR change? Adding TikTok in social links
  • Did you change something visual? A before/after screenshot can be helpful.
    image
    Just edited locally docs/astro.config.mjs.

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 1254a8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1254a8b
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66d10eb4f049a00008683445
😎 Deploy Preview https://deploy-preview-2265--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One thing, I am unsure of optimizing this one and will leave that to fellow maintainers

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution 🙌

I left tiny suggestions to the changeset, mostly to match our changeset conventions but other than these details, the PR looks perfect to me.

Note that this PR will only be merged when the next Starlight version is released so that the documentation is only updated when the feature is available to users.

One thing, I am unsure of optimizing this one and will leave that to fellow maintainers

Just ran the SVG in SVGOMG and it results to the same output so we should be good on that front. Thanks for the review too 👍

.changeset/rude-pets-complain.md Outdated Show resolved Hide resolved
.changeset/rude-pets-complain.md Outdated Show resolved Hide resolved
SeraphicRav and others added 2 commits August 30, 2024 09:13
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@SeraphicRav
Copy link
Contributor Author

Ok, thank you very much !

@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 2, 2024
@delucis delucis merged commit 25b661e into withastro:main Sep 2, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 2, 2024
@SeraphicRav SeraphicRav deleted the Adding-Tiktok branch September 3, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants