Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting unnecessary twitter meta tags, quick fixes #2137

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Deleting unnecessary twitter meta tags, quick fixes #2137

merged 5 commits into from
Jul 23, 2024

Conversation

cevdetardaharan
Copy link
Contributor

@cevdetardaharan cevdetardaharan commented Jul 22, 2024 •
edited
Loading

Description

  1. Deleting "twitter:" meta elements in favor of using "og:" as fallback.
  2. Deleting "initial-scale=1" because of it's default value.
  3. Reducing code size.

These changes won't make any difference in visual perspective, but they will reduce file size in this project and every project that uses Starlight.

Resources

Twitter and OG meta elements:

  1. https://developer.x.com/en/docs/twitter-for-websites/cards/guides/getting-started
  2. https://developer.x.com/en/docs/twitter-for-websites/cards/overview/markup

initial-scale=1:
https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

Controls the zoom level when the page is first loaded. Minimum: 0.1. Maximum: 10. Default: 1. Negative values: ignored.

@cevdetardaharan
Deleting "twitter:*" meta elements in favor of using "og:*" as fallba…
bbd2c73 
…ck, reducing code size and deleting "initial-scale=1" because of it's default value.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 52fdd55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 22, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 52fdd55
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/669fec0329549d0008034f67
😎 Deploy Preview https://deploy-preview-2137--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@cevdetardaharan cevdetardaharan changed the title … Deleting unnecessary twitter meta tags, quick fixes Jul 22, 2024
@github-actions github-actions bot added the 📚 docs Documentation website changes label Jul 22, 2024
delucis
delucis requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @cevdetardaharan. Left a couple of notes.

packages/starlight/components/Head.astro Outdated Show resolved Hide resolved
packages/starlight/components/Head.astro Outdated Show resolved Hide resolved
@delucis delucis mentioned this pull request Jul 23, 2024
Merged
@julien-deramond julien-deramond mentioned this pull request Jul 23, 2024
Merged
81 tasks
@delucis delucis merged commit 703903b into withastro:main Jul 23, 2024
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 23, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 6, 2024
@HiDeoo
Merge branch 'main' into hd-feat-link-button
0df0dde 
* main: (275 commits)
  [ci] release (withastro#2165)
  Define well-known RTL locales before calling `getLocaleInfo()` for default locale (withastro#2167)
  Update dependencies (withastro#2166)
  Improve page load performance (withastro#2155)
  docs: Add CodeSweetly to showcase (withastro#2160)
  [ci] release (withastro#2145)
  Fix bug for projects with spaces in their pathname (withastro#2156)
  ci: update file icons (withastro#2157)
  [ci] format
  Merge <link rel="canonical" /> tags, quick fixes (withastro#2153) (withastro#2154)
  Add two new showcase sites (withastro#2149)
  [ci] format
  i18n(zh-cn): Update `environmental-impact.md` (withastro#2148)
  add Saasfly showcase (withastro#2147)
  docs: add 'og:image:alt' metadata (withastro#2143)
  Deleting unnecessary twitter meta tags, quick fixes (withastro#2137)
  [ci] format
  i18n(es): update `environmental-impact` (withastro#2144)
  [ci] release (withastro#2142)
  feat: Add Pinterest icon to social list (withastro#2135)
  ...
This was referenced Aug 20, 2024
Open
Open
Open
Open
This was referenced Aug 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cevdetardaharan @astrobot-houston @delucis