Fixes an edge case in custom pagination link processing #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 17a7869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
delucis
changed the title
HiDeoo
approved these changes
Jul 6, 2024
packages/starlight/__tests__/basics/pagination-with-base.test.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Merged
This was referenced Aug 12, 2024
This was referenced Aug 19, 2024
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makeLink()utility designed for sidebar items that did some additional processing. This rarely caused issues, but if a user hadbaseset, this led to inconsistencies where the base would prepended to links only in these rare edge cases.xto/x, but I think that was a wrong expectation, so I updated that old test to reflect the new behaviour.