Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(uk): update packages/starlight/translations/uk.json #2081

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

andrii-bodnar
Copy link
Contributor

Description

  • What does this PR change?
    Update Ukrainian translations in packages/starlight/translations/uk.json

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: eb8f816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jul 3, 2024 4:53pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 3, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new translations @andrii-bodnar! Could you quickly explain the change to the search.devWarning message and why it is required?

@andrii-bodnar
Copy link
Contributor Author

andrii-bodnar commented Jul 3, 2024

@delucis thank you for the review! The previous translation was a bit incorrect. зборках - It's a misspelling.

P.S. I just reverted some of the changes related to the production word translation.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation! That’s always helpful as we often don’t have a second reviewer for these PRs with knowledge of the language and typos can be hard to catch with automated tooling.

Looks great to me! I will add a changeset, so this will be released in our next version.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jul 3, 2024
@delucis delucis merged commit f0181d2 into withastro:main Jul 3, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 3, 2024
@andrii-bodnar andrii-bodnar deleted the chore/update-translations branch July 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants