Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n routing RFC #734

Merged
merged 20 commits into from
Dec 4, 2023
Merged

i18n routing RFC #734

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6b5de3c
i18n routing
ematipico Oct 19, 2023
f2e9002
fixes
ematipico Oct 20, 2023
42f14b4
cookie => header
ematipico Oct 24, 2023
4718adb
chore: update APIs
ematipico Oct 24, 2023
b12d670
chore: reword file system description, and updated APIs
ematipico Oct 26, 2023
e07aef7
update browser locale detection and routing strategy
ematipico Oct 31, 2023
989ecc1
`prefix-other-locales` should return 404 instead
ematipico Nov 1, 2023
26ed3c6
`prefix-always` should redirect when navigating the root
ematipico Nov 6, 2023
c2128e6
Update proposals/0041-i18n-routing.md
ematipico Nov 9, 2023
38a80f0
Update proposals/0041-i18n-routing.md
ematipico Nov 9, 2023
6954fb2
routing strategy should skip endpoints
ematipico Nov 13, 2023
f934880
add `currentLocale` as new API
ematipico Nov 14, 2023
c93015d
Routing strategies are applied only to pages
ematipico Nov 15, 2023
713fce7
Add `domain` routing strategy
ematipico Nov 15, 2023
a63da81
Add information about headers
ematipico Nov 21, 2023
dc277b5
Add granular locales
ematipico Nov 27, 2023
22d192b
Remove domain support from this RFC
ematipico Nov 28, 2023
089253d
Change configuration for `routingStrategy`
ematipico Nov 29, 2023
1584ed5
chore: apply suggestions
ematipico Dec 4, 2023
30056ba
Update proposals/0041-i18n-routing.md
ematipico Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update proposals/0041-i18n-routing.md 
Co-authored-by:  Matthew Phillips <matthew@skypack.dev>
  • Loading branch information
@ematipico @matthewp
ematipico and matthewp authored Nov 9, 2023
commit 38a80f0ac7fb479b9085b643178a21ab959d6439
2 changes: 1 addition & 1 deletion proposals/0041-i18n-routing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ The feature requires **two required** fields, where the user needs to store the
import {defineConfig} from "astro/config"
export default defineConfig({
i18n: {
defaultLocaLe: 'en',
defaultLocale: 'en',
locales: ['en', 'es', 'pt', 'fr']
}
})
Expand Down