Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test macro 'PrettierMarkdown' #30

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

antonyfaris
Copy link
Member

@antonyfaris antonyfaris commented Oct 8, 2021

I removed some new lines according to the new changes in #26
If you have some input about the messages that I added please let me know since I'm not sure if they are descriptive enough.

Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but for one change

test/astro-prettier.test.mjs Outdated Show resolved Hide resolved
Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz>
@antonyfaris
Copy link
Member Author

lgtm but for one change

I changed the line. Is that all?

@jasikpark
Copy link
Collaborator

It looks good, there's some changes with the test that are related to changes I didn't see in #26, but I'll merge now!

@jasikpark jasikpark merged commit 8820423 into withastro:main Oct 8, 2021
@antonyfaris antonyfaris deleted the fix/test-prettier-markdown branch October 8, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants