Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codebase #245

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Refactor codebase #245

merged 4 commits into from
Aug 2, 2022

Conversation

Princesseuh
Copy link
Member

Changes

A common feedback about this codebase is that it's a bit hard to navigate, namely due to the large (in line counts) files and functions. This PR tries refactor things a bit by separating different parts in different files and functions where applicable.

Additionally, a lot of leftover code from the previous version was still left in the files. I decided to remove all of it, I'm sure some parts of it could be used in the future for other things, but I figured that we'd go get back those specific parts when needed (if we ever needed them)

In the future I would like to add more comments to explain different parts of the codebase, notably around the part that print HTML, however I'm hoping that this refactor helps make things at least a tiny bit more clearer already

Testing

No behaviour changes

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

⚠️ No Changeset found

Latest commit: 20726c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 1 small comment on file naming but consider it a nit to address or ignore as you see fit.

src/lib/elements.ts Outdated Show resolved Hide resolved
@Princesseuh Princesseuh merged commit 1adfd4a into main Aug 2, 2022
@Princesseuh Princesseuh deleted the refactor branch August 2, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants