Remove dedup utility #235
Merged
Remove dedup utility #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Princesseuh
reviewed
Jul 18, 2022
| @@ -38,7 +38,7 @@ | |||
| "format": "prettier -w . --cache" | |||
| }, | |||
| "dependencies": { | |||
| "@astrojs/compiler": "^0.15.2", | |||
| "@astrojs/compiler": "^0.19.0", | |||
There was a problem hiding this comment.
Does the compiler upgrade brings any other changes?
There was a problem hiding this comment.
I think it also comes with this one withastro/compiler#414
It's kind of hard to keep track of what is changed in the AST from the changelog, that's why I'm not sure how many changes were made but I found only those two.
There was a problem hiding this comment.
That one should already be in. It's very possible there was no other changes, I think it's fine to bump it. Tests still pass
Princesseuh
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs