Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve tag case #19

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

antonyfaris
Copy link
Member

Fixes #4
While fixing this I encounter an error with the test "with-script", so I also fix that.

@antonyfaris antonyfaris changed the title Preserve tag Case Preserve tag case Oct 1, 2021
Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the pr - i'll approve running CI and merge when it passes!

@jasikpark
Copy link
Collaborator

Pulled it down and tested locally - looks good! Hopefully my changes to the workflow in main will fix ci for the future

@jasikpark jasikpark merged commit 4b76988 into withastro:main Oct 3, 2021
@antonyfaris antonyfaris deleted the feature/preserve-tag-case branch October 3, 2021 01:05
@bobaekang
Copy link

@jasikpark I'm experiencing the same issue that this PR fixes. When can we expect a new release that includes this PR? Thank you in advance for your work 🙏

@github-actions github-actions bot mentioned this pull request Oct 4, 2021
@jasikpark
Copy link
Collaborator

@jasikpark I'm experiencing the same issue that this PR fixes. When can we expect a new release that includes this PR? Thank you in advance for your work 🙏

released! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG 🐛: <Footer> gets rewritten to <footer> + all other case insensitive html tag collisions
3 participants