set astroAllowShorthand to default off
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reply. This indeed will be the new default. We are in the process of migrating to the new Astro compiler. Thanks for opening this pr. |
|
@manigandham Could you please rebase on next & add a changeset? |
Shorthand removes attribute keys and breaks Typescript which is used by Astro. It's also uncommon and should be disabled by default, and only opt-in for those that specifically want it.
|
@antonyfaris done! |
|
@manigandham Can you fix the tests? Now that the default is false some tests are not to passing. |
- shorthand off by default - comment (and should remove) can format to shorthand because this is covered in the options test
Done. I commented out the |
antonyfaris
reviewed
Mar 28, 2022
|
All set |
|
Thank you! |
Princesseuh
added a commit
that referenced
this pull request
Jun 24, 2022
* [WIP] Add new compiler (#135) * add new compiler * chore: update compiler, make-synchronous * chore: use compiler's AST types * feat: use new Astro compiler * fix: use `type` keyword for type exports * fix: update compiler * remove old parser * wip: format basic Astro file * bump @astrojs/compiler * fix: format basic Astro file * bump @astrojs/compiler * fix: format with a single style element * format frontmatter and simple expression * fix: format with embedded JSX expressions * fix: JSX expressions in attribute values * format html comments * format shorthand * fix: format components * format unclosed tags * fix: format script tag * format with prettier ignore in frontmatter * fix: format spread operator * format nested comment * fix: format attribute with expression as value * uncomment working tests * fix: format style element content and attributes * fix: format style element with sass and scss * bump compiler * fix: inline element white space * fix: format fragments * fix: format markdown content * enter pre release mode * fix: pre release workflow * run ci and format workflows on next branch Co-authored-by: Nate Moore <nate@skypack.dev> * add changeset * change version from patch to minor * Version Packages (next) (#148) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [ci] yarn format * fix: skip handling comments * Version Packages (next) (#149) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [ci] yarn format * Move from ava to vitest (#151) * Move from ava to vitest * chore: add changeset * Fix eslint (#153) * fix: eslint * retrigger checks * remove node 12 from ci (#154) * chore: add changeset * Change prettier width (#155) * chore: change prettier width from 180 to 80 * chore: add changeset * fix: format expression (#150) * Format `directives` (#156) * format directives * chore: add changeset * chore: fix test title * Version Packages (next) (#152) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update readme & contributing (#157) * set `astroAllowShorthand` to default off (#143) * set `astroAllowShorthand` to default off Shorthand removes attribute keys and breaks Typescript which is used by Astro. It's also uncommon and should be disabled by default, and only opt-in for those that specifically want it. * Create selfish-cherries-grab.md * fix tests for shorthand formatting - shorthand off by default - comment (and should remove) can format to shorthand because this is covered in the options test * remove obsolete shorthand tests, update changeset * Version Packages (next) (#161) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * try out synckit (#166) * Version Packages (next) (#167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Refactor tests for better watch mode (#170) * Refactor tests for better watch mode * small refactor * Update dependencies (#172) * Fix: format indented sass (#173) * Fix: format indented sass * chore: add changeset * Disable vitest multi-threading (#176) * Fix: duplicate text (#177) * Fix: prevent duplicate text * typo * Add new line after comments (#178) * Add new line after comments * chore: add changeset * Refactor test-utils (#179) * Update @astrojs/compiler and fix for spread in expression (#206) * Update @astrojs/compiler and fix for spread in expression * add changeset * Version Packages (next) (#171) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Cleanup repo (#216) * Update README * Update configuration files * Format repo with new rules * Add .git-blame-ignore-revs * Update CONTRIBUTING.md * Update links in package.json * Fix README example indentation * Fix README mistake, update ignore-revs id to right one * Exit pre mode Co-authored-by: Antony Faris <acp325@gmail.com> Co-authored-by: Nate Moore <nate@skypack.dev> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: antonyfaris <antonyfaris@users.noreply.github.com> Co-authored-by: Mani Gandham <manigandham@gmail.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com> Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorthand removes attribute keys and breaks Typescript which is used by Astro. It's also uncommon and should be disabled by default, and only opt-in for those that specifically want it.
Changes
astroAllowShorthandto defaultfalseTesting
No new tests.
Docs
No documentation to update.