Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(de): update basics/astro-components.mdx #9754

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

i18n(de): update basics/astro-components.mdx #9754

wants to merge 5 commits into from
+17 −13

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Oct 20, 2024 •
edited
Loading

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 20, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ac43c03
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6716ac3f2caa0400080b73e7
😎 Deploy Preview https://deploy-preview-9754--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 20, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de basics/astro-components.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless trueberryless marked this pull request as ready for review October 21, 2024 19:33
Maxframe
Maxframe reviewed Oct 25, 2024
View reviewed changes
src/content/docs/de/basics/astro-components.mdx


```astro title="src/components/CustomTable.astro" "<slot name="header"/>" "<slot name="body"/>"
```astro title="src/components/CustomTable.astro" '<slot name="header" />' '<slot name="body" />'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to handle this one here, since they are currently not being highlighted in the English version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just highlight them cause I think it's intended to be highlighted.

@trueberryless
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxframe Maxframe Maxframe left review comments

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueberryless @astrobot-houston @Maxframe