Skip to content

Comments

Improve import docs#9711

Merged
yanthomasdev merged 4 commits intowithastro:mainfrom
apatel369:patch-6
Oct 17, 2024
Merged

Improve import docs#9711
yanthomasdev merged 4 commits intowithastro:mainfrom
apatel369:patch-6

Conversation

@apatel369
Copy link
Contributor

@apatel369 apatel369 commented Oct 17, 2024

Description (required)

This PR adds advanced guide links for importing CSS and other assets.
Content is copied from Sarash's comment in #8417 except links.

Related issues & labels (optional)

@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 62bdf18
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67113cad5dfa7f0008840eed
😎 Deploy Preview https://deploy-preview-9711--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 17, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/imports.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you for snagging this issue @apatel369 ! 🙌

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Oct 17, 2024
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Oct 17, 2024
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@yanthomasdev yanthomasdev merged commit ba9fcbe into withastro:main Oct 17, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 17, 2024
yanthomasdev added a commit that referenced this pull request Oct 18, 2024
* i18n(fr): update `guides/imports.mdx`

See #9711

* remove unwanted backtick (there was one left...)

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@apatel369 apatel369 deleted the patch-6 branch November 20, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document ?url usage in Imports docs

4 participants