Skip to content

Comments

Clarify framework dependency for JSX files#8981

Merged
delucis merged 2 commits intowithastro:mainfrom
kjkent:jsx-imports
Aug 2, 2024
Merged

Clarify framework dependency for JSX files#8981
delucis merged 2 commits intowithastro:mainfrom
kjkent:jsx-imports

Conversation

@kjkent
Copy link
Contributor

@kjkent kjkent commented Aug 1, 2024

Description (required)

Clarifies that a UI framework is required to import and render JSX/TSX files. My first PR here! I'm happy to make any amendments as seen fit :)

I just joined the Astro Discord, username is footnuke

Related issues & labels (optional)

@netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit d9539ac
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ac88e052b58500082b8156
😎 Deploy Preview https://deploy-preview-8981--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 1, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@kjkent kjkent mentioned this pull request Aug 1, 2024
Closed
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 1, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/imports.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for going all the way in with this one

delucis
delucis approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kjkent!

@delucis delucis merged commit 1e26130 into withastro:main Aug 2, 2024
@jsparkdev jsparkdev mentioned this pull request Aug 2, 2024
Merged
@liruifengv liruifengv mentioned this pull request Aug 2, 2024
Merged
@kjkent
Copy link
Contributor Author

kjkent commented Aug 2, 2024

Thanks both!

"It ain't much, but it's honest work" :')

ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 2, 2024
@ArmandPhilippot
i18n(fr): update guides/imports.mdx
a762990 
Apply changes from withastro#8981
@ArmandPhilippot ArmandPhilippot mentioned this pull request Aug 2, 2024
Merged
yanthomasdev added a commit that referenced this pull request Aug 2, 2024
@ArmandPhilippot @thomasbnt @yanthomasdev
i18n(fr): update guides/imports.mdx (#9000)
4736c34 
* i18n(fr): update guides/imports.mdx

Apply changes from #8981

* i18n(fr): reword UI framework

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@Nin3lee Nin3lee mentioned this pull request Aug 8, 2024
Merged
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
@morinokami morinokami mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

+1 more reviewer

@at-the-vr at-the-vr at-the-vr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feedback-improvement Response to widget/Discord feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request: Clarify "out-of-the-box" JSX/TSX support

5 participants

@kjkent @astrobot-houston @delucis @at-the-vr @sarah11918