i18n(fr): add upgrade-to/vX.mdx guides#8772
Merged
yanthomasdev merged 12 commits intowithastro:mainfrom Jul 19, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
i18n
ArmandPhilippot
force-pushed
the
i18n/fr-add-guides/upgrade-to/vX.mdx
branch
from
103c537 to
f2aa44a
Compare
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
commented
Jul 13, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Jul 17, 2024
* Remove all mentions of jsconfig in French guides and references (see withastro#8818) Note: `src/content/docs/en/guides/upgrade-to/v1.mdx` is not included since it does not exist yet. I'll update the translation in withastro#8772.
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Jul 19, 2024
* i18n(fr): remove jsconfig mentions in guides and references * Remove all mentions of jsconfig in French guides and references (see #8818) Note: `src/content/docs/en/guides/upgrade-to/v1.mdx` is not included since it does not exist yet. I'll update the translation in #8772. * i18n(fr): add changes from minor release docs Add changes only for `reference/cli-reference.mdx`. See #8796 --------- Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev
approved these changes
Jul 19, 2024
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
Damn, this is a big one, LGTM! I hope y'all are ready for the V5 upgrade guide 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
upgrade-to/v1.mdx) (including changes made in Remove all mentionedjsconfig#8818)upgrade-to/v2.mdx)upgrade-to/v3.mdx)upgrade-to/v4.mdx)fr/reference/errors/invalid-get-static-paths-entry.mdxnoticed while updating anchors inv3.mdxRelated issues & labels (optional)
Additional notes about translation
I added a PR comment in
upgrade-to/v3.mdxaboutshimsto find out whether you think this word should be translated or not.I had doubts on how to translate
Breaking changesin the different guides, so I leave my reasoning here:Modifications majeurescould be right but we loose the "breaking" aspectChangements majeurs avec rupture de compatibilitébut it seems too verbose to repeat it in the sentencesChangements cassants/Modifications cassantesand sometimesmajeursto avoid repeatsIn both cases, feel free to leave a suggestion if you have a better idea!