Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Content Collection Caching #7535

Merged
merged 9 commits into from
Apr 18, 2024
Merged

feat: enable Content Collection Caching #7535

merged 9 commits into from
Apr 18, 2024

Conversation

Princesseuh
Copy link
Member

Description (required)

Maybe I could've tried this before, sorry for the time loss.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 18, 2024 6:19pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 18, 2024 6:19pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 16, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en recipes/build-forms.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@delucis
Copy link
Member

delucis commented Apr 17, 2024

Adding a quick note that I’m not 100% confident we can rely on Vercel to test the cache hit in this case — tried rerunning the deploy there a few times with build cache enabled, but it always logs:

Cache invalid, rebuilding from source. Reason: The cache manifest version has changed.

I think this is because Vercel only caches node_modules from main not from deploy branches so the lock file has always changed on branch deploy? Not sure, but just a heads up.

@matthewp
Copy link
Contributor

@delucis that's what I was going to test today, thanks!

@matthewp
Copy link
Contributor

I think in this case a code issue is causing it to continuously be invalidated. I'm working on a fix while writing tests.

@matthewp matthewp merged commit dec2bc7 into main Apr 18, 2024
8 checks passed
@matthewp matthewp deleted the feat/ccc branch April 18, 2024 18:27
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* feat: enable Content Collection Caching

* fix: disable inlineStylesheets

* force rebuild

* Update CCC version

* Combine experimental config

* Change one thing

* change

* Add a check for debugging

* Remove changes

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* feat: enable Content Collection Caching

* fix: disable inlineStylesheets

* force rebuild

* Update CCC version

* Combine experimental config

* Change one thing

* change

* Add a check for debugging

* Remove changes

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants