Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document new behavior(vercel, netlify): edge middleware verification #6786

Merged
merged 7 commits into from
Feb 7, 2024
Merged

document new behavior(vercel, netlify): edge middleware verification #6786

merged 7 commits into from
Feb 7, 2024

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Feb 6, 2024 •
edited
Loading

Description (required)

Enabling edgeMiddleware will now involve a check to prevent anyone but the generated middleware from providing locals.

Related issues & labels (optional)

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 6, 2024 5:16pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Feb 6, 2024 5:16pm

This was referenced Feb 6, 2024
Merged
Merged
sarah11918
sarah11918 reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilnasy -- really nice content here! I mostly just want these paragraphs a little shorter for readability!

src/content/docs/en/guides/integrations-guide/netlify.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/vercel.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/vercel.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Feb 6, 2024
@lilnasy @sarah11918
Apply suggestions from code review
f25d0eb 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@lilnasy @sarah11918
Apply suggestions from code review
4605150 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@lilnasy @sarah11918
Apply suggestions from code review
54bda7d 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily approved!

@lilnasy lilnasy merged commit c5cc68a into main Feb 7, 2024
7 checks passed
@lilnasy lilnasy deleted the edge-middleware-verification branch February 7, 2024 18:26
This was referenced Feb 8, 2024
Merged
Merged
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilnasy @sarah11918