-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default image service section #6073
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll let Sarah make the call of when to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Since the specific Sharp config option isn't actually live until the minor release, I'll save this to merge with the other release docs. But, we should have had a link to config reference regardless, so this is perfect!
Description (required)
From withastro/astro#9546 (comment), Sarah suggested that the "Default image service" section could have a link to the
image.service
option explaning how to configure options for an image service.Related issues & labels (optional)
For Astro version:
4.1
. See astro PR withastro/astro#9546Don't think there's a big harm if we merge this without waiting for withastro/astro#9546? I guess I'll let y'all decide so the PR is properly labelled 😅