Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default image service section #6073

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 3, 2024

Description (required)

From withastro/astro#9546 (comment), Sarah suggested that the "Default image service" section could have a link to the image.service option explaning how to configure options for an image service.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.1. See astro PR withastro/astro#9546

Don't think there's a big harm if we merge this without waiting for withastro/astro#9546? I guess I'll let y'all decide so the PR is properly labelled 😅

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 3:11am

Copy link
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let Sarah make the call of when to merge.

@yanthomasdev yanthomasdev added minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) and removed minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 3, 2024
@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 3, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Since the specific Sharp config option isn't actually live until the minor release, I'll save this to merge with the other release docs. But, we should have had a link to config reference regardless, so this is perfect!

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.1.0 January 3, 2024 17:32
@sarah11918 sarah11918 merged commit 06242cb into 4.1.0 Jan 4, 2024
3 of 4 checks passed
@sarah11918 sarah11918 deleted the default-image-service branch January 4, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants