Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18nIgnore][prefetch.mdx]: Adds a load prefetch strategy #5967

Merged
merged 9 commits into from
Jan 4, 2024
Merged

[i18nIgnore][prefetch.mdx]: Adds a load prefetch strategy #5967

merged 9 commits into from
Jan 4, 2024

Conversation

wtto00
Copy link
Contributor

@wtto00 wtto00 commented Dec 27, 2023

Description (required)

Adds a 'load' prefetch strategy to prefetch links on page load

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.x. See astro PR #9513.

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 4, 2024 0:36am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 0:36am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 27, 2023
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

sarah11918
sarah11918 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English contribution is approved! Trying an experiment to see if we can get all the other language reviews in this PR, too!

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Dec 27, 2023
@bluwy bluwy mentioned this pull request Jan 2, 2024
Merged
@liruifengv
Copy link
Member

Just a punctuation mark. Everything else is great in zh-cn.

yanthomasdev
yanthomasdev reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wtto00, left a few couple nits.

src/content/docs/en/guides/prefetch.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/prefetch.mdx Outdated Show resolved Hide resolved
wtto00 and others added 2 commits January 3, 2024 23:19
@wtto00 @yanthomasdev
Update src/content/docs/en/guides/prefetch.mdx
e988ba6 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@wtto00 @yanthomasdev
Update src/content/docs/es/guides/prefetch.mdx
9dbb0a6 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 3, 2024
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
@sarah11918 sarah11918 changed the title [prefetch.mdx]: Adds a load prefetch strategy [i18nIgnore][prefetch.mdx]: Adds a load prefetch strategy Jan 3, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.1.0 January 3, 2024 17:33
Waxer59
Waxer59 reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion on the translation of es.

src/content/docs/es/guides/prefetch.mdx Outdated Show resolved Hide resolved
@sarah11918 @Waxer59
es translation update
3932061 
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
@sarah11918 sarah11918 merged commit 13a552f into withastro:4.1.0 Jan 4, 2024
3 of 4 checks passed
@wtto00 wtto00 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@Waxer59 Waxer59 Waxer59 left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

@liruifengv liruifengv liruifengv approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wtto00 @astrobot-houston @liruifengv @sarah11918 @yanthomasdev @Waxer59