-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document caveats with using ViewTransitions component #3810
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, @matthewp! Reminder DO NOT BLINDLY TRUST ME. (Though, that's often a great strategy....)
There are some "question/fill-in-the-blanks" here for you! 😄
@@ -217,3 +217,34 @@ import { ViewTransitions } from 'astro:transitions'; | |||
:::note[known limitations] | |||
The `morph` animation cannot be simulated in traditional CSS. So any element using this animation will not be animated. | |||
::: | |||
|
|||
## Caveats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about this one, but I'm thinking of something less "WARNING" and more "Script behavior during page navigation"
Any thoughts about a more descriptive (and less maybe warning-sounding heading here?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, after talking on Discord I think this is more about scripts and not general caveats.
Also checking, @matthewp, is this waiting on a new release? 2.9.2 went out this morning, but your implementation PR is still open. Is this for 2.9.3? |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 yeah, whichever the next patch release is. Hopefully 2.9.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I really like these changes. I'll keep an eye out for the next patch release to know when this should be merged. 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
What kind of changes does this PR include?
Description
<ViewTransitions />
component.For Astro version:
2.9.2
. See Astro PR #7786.