Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document caveats with using ViewTransitions component #3810

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Conversation

matthewp
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

For Astro version: 2.9.2. See Astro PR #7786.

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e1a44ad
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64c023dd802a2200085887f2
😎 Deploy Preview https://deploy-preview-3810--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, @matthewp! Reminder DO NOT BLINDLY TRUST ME. (Though, that's often a great strategy....)

There are some "question/fill-in-the-blanks" here for you! 😄

@@ -217,3 +217,34 @@ import { ViewTransitions } from 'astro:transitions';
:::note[known limitations]
The `morph` animation cannot be simulated in traditional CSS. So any element using this animation will not be animated.
:::

## Caveats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about this one, but I'm thinking of something less "WARNING" and more "Script behavior during page navigation"

Any thoughts about a more descriptive (and less maybe warning-sounding heading here?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, after talking on Discord I think this is more about scripts and not general caveats.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jul 24, 2023
@sarah11918
Copy link
Member

Also checking, @matthewp, is this waiting on a new release? 2.9.2 went out this morning, but your implementation PR is still open. Is this for 2.9.3?

matthewp and others added 4 commits July 24, 2023 16:20
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp
Copy link
Contributor Author

@sarah11918 yeah, whichever the next patch release is. Hopefully 2.9.3

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I really like these changes. I'll keep an eye out for the next patch release to know when this should be merged. 🙌

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@matthewp matthewp merged commit 17ff293 into main Jul 25, 2023
@matthewp matthewp deleted the vt-load branch July 25, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants