Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update migration guide for clarity #327

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

natemoo-re
Copy link
Member

Taking some feedback from Discord, our Migration Guides are great about noting what has changed but are lacking a bit on the "migration" piece.

This PR is intended to refresh our migration guide and clarify exactly how one can expect to migrate from deprecated APIs to their replacements.

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 181db7a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/624f6175ff55a80009a4e0a4
😎 Deploy Preview https://deploy-preview-327--astro-docs-2.netlify.app/en/migrate
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think ZERO breaking changes is a bit tough to hit, we've already seen a few bug fixes that technically change existing behavior. I might rewrite this a bit post-merge to soften this, and also give us a section on the page to call out any changes that the reader should be aware of.

@FredKSchott FredKSchott marked this pull request as ready for review April 11, 2022 23:12
@FredKSchott FredKSchott merged commit 5455ce9 into main Apr 11, 2022
@FredKSchott FredKSchott deleted the feat/migration-guide-clarity branch April 11, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants