Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pnpx to pnpm dlx #2964

Merged
merged 2 commits into from
Mar 30, 2023
Merged

update pnpx to pnpm dlx #2964

merged 2 commits into from
Mar 30, 2023

Conversation

ElianCodes
Copy link
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

Switches pnpx for pnpm dlx since pnpx is deprecated documented here

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7b4142
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64256f4e9c0ede000831fb86
😎 Deploy Preview https://deploy-preview-2964--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

Thanks, @ElianCodes! Just checking: does this require someone to have upgraded to the latest version of pnpm? And if so, is it reasonable to assume that they have? (You know how sometimes we have different instructions for different versions of things?)

Just want to make sure that this is now-universal advice, then it's good to go!

@ElianCodes
Copy link
Member Author

Hey @sarah11918, nope! The pnpm dlx command has been there since some time now! So even on 'outdated' pnpm versions, the pnpx command is also backwards compatible and still works, but is not recommended to use anymore. So we should be good to merge this!

(the pnpx was actually deprecated since version 6.x, most users are on 7.x or 8.x)

@sarah11918
Copy link
Member

Sounds good! Then Let's Get That Money!

@sarah11918 sarah11918 merged commit fab71c4 into withastro:main Mar 30, 2023
@ElianCodes ElianCodes deleted the fix-pnpx branch April 2, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants